Skip to content

feat: add toArray function to convert NodeList to Array#603

Merged
jedrzejchalubek merged 1 commit intoglidejs:masterfrom
samuelfullerthomas:master
Feb 9, 2022
Merged

feat: add toArray function to convert NodeList to Array#603
jedrzejchalubek merged 1 commit intoglidejs:masterfrom
samuelfullerthomas:master

Conversation

@samuelfullerthomas
Copy link
Copy Markdown
Contributor

  • for ie11 compatibility

@samuelfullerthomas
Copy link
Copy Markdown
Contributor Author

samuelfullerthomas commented Feb 8, 2022

Ran into an issue with ie11 throwing for the resetArrowState function, and so wrote this to make the forEach compatible with ie11, which doesn't support forEach for NodeList.

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#browser_compatibility

Screenshot 2022-02-08 at 10 58 06

@jedrzejchalubek jedrzejchalubek merged commit 9bf8f46 into glidejs:master Feb 9, 2022
@jedrzejchalubek
Copy link
Copy Markdown
Member

Looks nice! Merging, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants