Skip to content

Adjust ICOADS wind direction values#82

Merged
ludwiglierhammer merged 20 commits into
glamod:mainfrom
ludwiglierhammer:icoads_wd
Aug 29, 2024
Merged

Adjust ICOADS wind direction values#82
ludwiglierhammer merged 20 commits into
glamod:mainfrom
ludwiglierhammer:icoads_wd

Conversation

@ludwiglierhammer

Copy link
Copy Markdown
Collaborator

see glamod/glamod-marine-processing#20

  • 361 to 0
  • 362 to np.nan

@codecov

codecov Bot commented Aug 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (bdd30e8) to head (b8ee9cc).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   83.90%   83.94%   +0.04%     
==========================================
  Files          62       62              
  Lines        2535     2542       +7     
==========================================
+ Hits         2127     2134       +7     
  Misses        408      408              
Flag Coverage Δ
unittests 83.94% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludwiglierhammer

ludwiglierhammer commented Aug 20, 2024

Copy link
Copy Markdown
Collaborator Author

set some WD testdata to both 361 and 362:

  • 714 -> not necessary: values taken from c99 attachment ([0.00,360.00])
  • 703 -> done

@ludwiglierhammer ludwiglierhammer merged commit d6d854a into glamod:main Aug 29, 2024
@ludwiglierhammer ludwiglierhammer deleted the icoads_wd branch August 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant