You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to: plotly/plotly.js#4550
Looks to fix interactivity in 3d plots on mobile and tablet devices.
I'm not sure what the best way is to test this and that it doesn't break anything else. But I did test by making these changes on the plotly.js repo at a commit that was before camera.js was moved to this repo.
@archmoj there are no changes required plotly.js, the updates here should cover it. I can create a PR in plotly.js just for testing purposes if it's easier for you.
@archmoj there are no changes required plotly.js, the updates here should cover it. I can create a PR in plotly.js just for testing purposes if it's easier for you.
@jdpaterson
In plotly.js we need to upgrade to a patch including this commit. And yes it would help with testing as well.
So please submit a PR there and mention this PR in the description or alternatively in a comment on the package.json changes.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: plotly/plotly.js#4550
Looks to fix interactivity in 3d plots on mobile and tablet devices.
I'm not sure what the best way is to test this and that it doesn't break anything else. But I did test by making these changes on the plotly.js repo at a commit that was before camera.js was moved to this repo.