Skip to content

Update builds for new Xcode version 26#489

Merged
hannesa2 merged 1 commit intomasterfrom
update-xcode
Nov 8, 2025
Merged

Update builds for new Xcode version 26#489
hannesa2 merged 1 commit intomasterfrom
update-xcode

Conversation

@jspiro
Copy link
Copy Markdown
Member

@jspiro jspiro commented Nov 8, 2025

Updated Xcode version and macOS configuration in the workflow. Pulled ARM artifact for macOS 26 and confirmed it works.

@jspiro jspiro marked this pull request as draft November 8, 2025 06:54
@jspiro jspiro changed the title Modify BuildPR.yml for new Xcode and macOS versions Update builds for new Xcode version Nov 8, 2025
@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Nov 8, 2025

I already fixed on thing on master, that pull request and release using the same Xcode version. Because on release it works properly.
But on a current unknown reason, the release pipeline comes with Xcode selection issue

@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Nov 8, 2025

I guess, I found it
image

It's included in https://github.com/gitx/gitx/actions/runs/19189839867/job/54862625646

@jspiro
Copy link
Copy Markdown
Member Author

jspiro commented Nov 8, 2025

The change on this branch seemed to work, not sure what I'm missing–but you know more about the build matrix.

@jspiro jspiro marked this pull request as ready for review November 8, 2025 07:22
@jspiro
Copy link
Copy Markdown
Member Author

jspiro commented Nov 8, 2025

Just used the gitx built from this pr artifact to rebase it cleanly, so seems good 🤷🏻

@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Nov 8, 2025

This is the fix #490

@jspiro
Copy link
Copy Markdown
Member Author

jspiro commented Nov 8, 2025

Do we need #490 in this PR? #490 doesn't specify using xcode 26, which is essential.

@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Nov 8, 2025

Fixing release pipeline is always annoying. You can't do it in a pull request.
As it looks like, there were several issues:

@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Nov 8, 2025

Do we need #490 in this PR? #490 doesn't specify using xcode 26, which is essential.

But pull request pipeline works, my goal is to have it work and then update it to 26.
Or why does pull request pipeline works without 26 ?

@hannesa2 hannesa2 merged commit ac70ecd into master Nov 8, 2025
2 checks passed
@hannesa2 hannesa2 deleted the update-xcode branch November 8, 2025 07:33
@hannesa2 hannesa2 added the pipeline CI pipeline label Nov 8, 2025
@hannesa2 hannesa2 changed the title Update builds for new Xcode version Update builds for new Xcode version 26 Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipeline CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants