Conversation
|
Hm just saw from https://github.com/gitx/gitx/actions/runs/8306072213/job/22733712786 : Perhaps we'll need to update the build to support MacOS 12 and above only? |
Now you see the error again 👍 |
|
@hannesa2 I'm testing out unlinking |
|
Unfortunately, I've to push always a button to make your branch build on CI. |
Hm I think you can approve permissions for me to allow me to run CI. Running it on my fork probably won't work since it doesn't have the certificates set up. But looks like the fix b8c4d19 worked. See logs in https://github.com/gitx/gitx/actions/runs/8417015697/job/23044846310 . I can clean up the commits so that this PR is mergeable. |
Perhaps the CI script can be adjusted to remove the `brew install openssl` parts, but I wanted to keep the changes minimal since I don't have permissions to keep re-running CI on this repository.
c41db99 to
d83e7be
Compare
|
Cleaned up the commits with a description. |
|
Nice, thank you |
| - name: Show openssl version | ||
| run: | | ||
| openssl version | ||
| - name: Unlink openssl 3 |
There was a problem hiding this comment.
I see, this was the breaking change
This reverts commit 5eebaa0, then applies a fix for the build by unlinking openssl.
Previously, the openssl@3 version installed seemed to be causing a conflict in the build.
I tested this locally and verified it on the PR.