Add a link to Applications in the DMG file#378
Merged
hannesa2 merged 1 commit intogitx:masterfrom Feb 27, 2023
Merged
Conversation
Contributor
Author
Contributor
|
Works fine on my side as well 👍 Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362
Notice
@hannesa2 this cannot be fully tested in the forked PR because the CI step with the change will be skipped.
I partially tested it though in #377 by enabling the
Prepare artifactstep. The DMG files work correctly, but the GitX app won't run due to the lack of signing (which we fixed already in #376).If needed to confirm a full test, please use an origin PR to do an integration test with
xcodebuild -exportArchive.Screenshot