Skip to content

Add a link to Applications in the DMG file#378

Merged
hannesa2 merged 1 commit intogitx:masterfrom
ADTC:applications-in-dmg
Feb 27, 2023
Merged

Add a link to Applications in the DMG file#378
hannesa2 merged 1 commit intogitx:masterfrom
ADTC:applications-in-dmg

Conversation

@ADTC
Copy link
Copy Markdown
Contributor

@ADTC ADTC commented Feb 27, 2023

Fixes #362

Notice

@hannesa2 this cannot be fully tested in the forked PR because the CI step with the change will be skipped.

I partially tested it though in #377 by enabling the Prepare artifact step. The DMG files work correctly, but the GitX app won't run due to the lack of signing (which we fixed already in #376).

If needed to confirm a full test, please use an origin PR to do an integration test with xcodebuild -exportArchive.

  • The generated DMG files should work correctly in both platforms. (This works.)
  • Dragging GitX onto Applications should install it. Finder may ask to replace existing copy. (This works.)
  • Installed GitX should run without issues or crashes. (This doesn't work in forked PR due to lack of signing.)

Screenshot

image

@ADTC
Copy link
Copy Markdown
Contributor Author

ADTC commented Feb 27, 2023

Tested artifacts from #379. Works fine on my end! @hannesa2 good to merge.

@hannesa2 hannesa2 merged commit d504aee into gitx:master Feb 27, 2023
@hannesa2
Copy link
Copy Markdown
Contributor

Works fine on my side as well 👍 Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DMG file has no shortcut to Applications

2 participants