Run notarization not from fork pull requests#369
Merged
Conversation
On a fork the variables are missing
Contributor
|
Hey, thanks for this! I just sat down to take a look. It's looking really good. I saw the forked PR test done in #368. |
ADTC
approved these changes
Feb 26, 2023
Contributor
|
I noticed the "Prepare artifact" step was skipped in #368 so there were no artifacts uploaded. My idea was to have two steps, one called "Prepare artifact (origin)" and another "Prepare artifact (fork)", and to run one of them depending on The second one would just run the Although now that I think about it, we probably shouldn't allow binary artifacts from forked PRs to be available publicly for security reasons. Is that why we aren't including artifacts in the forked PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a fork the variables are missing