Revert changes from #334 on BuildPR workflow file#365
Revert changes from #334 on BuildPR workflow file#365ADTC wants to merge 1 commit intogitx:masterfrom
Conversation
Pull requests opened from forks will not have access to secrets and variables. We don't need to notarize builds on the master branch or on pull requests. Only the builds from BuildRelease workflow file need to be notarized before making a release.
|
@hannesa2 please approve this so we can see whether the builds pass on this forked PR. Then kindly merge, and I can rebase my other PR on it. Thanks. Note that releases will still have the Apple certificate and notarization as they are through the BuildRelease workflow. Only master and PRs will no longer have it. BTW if you really want the notarization to happen on CC @insha |
|
@claytonrcarter Can you please cancel and re-run the ARM64 build? Seems it's stuck waiting for over 2 hours:
|
|
The auto start of arm actions-runner is broken. I've to start it manually in the meantime |
|
@claytonrcarter please ignore my last comment. It has finally run. Thank you. All checks passed; ready to merge. @hannesa2 BTW, could you help me with #366? |
hannesa2
left a comment
There was a problem hiding this comment.
I want to see the usage on every pull request and on master too.
- This prevent of "surprises" on a release
- you can use any master builds without security concerns of MacOS
Yes, the disadvantage of this is a non-buildable-fork because of missing variables.
If you want to have a working fork build as well, I recommend a if-condition when variables are missing and skip step in pipeline.
|
In that case I'll have a think of this tomorrow and open a new PR. Right now my brain is fried and I need to 💤 . Closing this one because the requirements changed fully and these changes will have to be reverted anyway. |
Pull requests opened from forks will not have access to secrets and variables. We don't need to notarize builds on the master branch or on pull requests. Only the builds from BuildRelease workflow file need to be notarized before making a release.
This reverts changes from #334 on BuildPR workflow file.