Skip to content

Improve the build & installation instructions#364

Merged
hannesa2 merged 1 commit intogitx:masterfrom
ADTC:patch-1
Feb 26, 2023
Merged

Improve the build & installation instructions#364
hannesa2 merged 1 commit intogitx:masterfrom
ADTC:patch-1

Conversation

@ADTC
Copy link
Copy Markdown
Contributor

@ADTC ADTC commented Feb 25, 2023

Direct readers to the Releases page to get the pre-built release so they can use it immediately. Also update the information about building from source code.

@ADTC
Improve the build & installation instructions
c19a288 
Direct readers to the Releases page to get the pre-built release so they can use it immediately. Also update the information about building from source code.
hannesa2
hannesa2 previously approved these changes Feb 25, 2023
View reviewed changes
@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Feb 25, 2023

What's going on there ?
image

@ADTC
Copy link
Copy Markdown
Contributor Author

ADTC commented Feb 25, 2023

@hannesa2 I'm not sure. Since I only changed the README I don't suppose I caused it. I saw the other recent pull requests also have build failures.

It could be something related to the notarization in #334 and #339. @insha please help.

@ADTC ADTC requested a review from hannesa2 February 25, 2023 15:02
@ADTC
Copy link
Copy Markdown
Contributor Author

ADTC commented Feb 25, 2023 •
edited
Loading

@hannesa2 It looks like the workflows run from these PRs opened from forks with NEVER be able to access the secrets. This is a GitHub limitation, so they will ALWAYS fail no matter what. The only way to have passing workflows is for you to get the changes into a branch here and open a new PR here (not from a fork).

image

It is pretty ridiculous if you ask me. Anyway, my change is only on the README file. I'd like to see it merged.

Update:

It looks like using pull_request_target or workflow_run should be able to help resolve the issue. See this comment and this documentation. These will not work. See my comment here.

@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Feb 25, 2023

Two weeks ago it was working properly,
image

I've to investigate what's the new root cause here.

@hannesa2
Copy link
Copy Markdown
Contributor

hannesa2 commented Feb 26, 2023

please rebase

hannesa2
hannesa2 previously approved these changes Feb 26, 2023
View reviewed changes
@ADTC
Copy link
Copy Markdown
Contributor Author

ADTC commented Feb 26, 2023

@hannesa2 done. 1 workflow awaiting approval.

@ADTC ADTC requested a review from hannesa2 February 26, 2023 08:18
@hannesa2 hannesa2 merged commit c4ee87d into gitx:master Feb 26, 2023
@ADTC ADTC deleted the patch-1 branch February 26, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannesa2 hannesa2 Awaiting requested review from hannesa2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ADTC @hannesa2