Skip to content

Trying to fix visual glitches appearing on Mac OS 10.x#349

Merged
hannesa2 merged 1 commit intogitx:masterfrom
elosha:guifixes
Nov 15, 2022
Merged

Trying to fix visual glitches appearing on Mac OS 10.x#349
hannesa2 merged 1 commit intogitx:masterfrom
elosha:guifixes

Conversation

@elosha
Copy link
Copy Markdown
Contributor

@elosha elosha commented Nov 14, 2022

Just a try to fix #348.

  • Added separator in main window footer area
  • Added some extra spacing to toolbar segmented buttons

Disclaimer:

  • Wasn't able to compile to test properly
  • Was unsure which how many automatic modifications by Xcode I had to cut out again

@hannesa2
Copy link
Copy Markdown
Contributor

Cool, do you have a screenshot before and after this change ?
It would help me a lot

@hannesa2
Copy link
Copy Markdown
Contributor

@insha Do you understand what's going on in pull request ? There were no changes here at all.

security: SecKeychainItemImport: One or more parameters passed to a function were not valid.

image

@elosha
Copy link
Copy Markdown
Contributor Author

elosha commented Nov 14, 2022

Cool, do you have a screenshot before and after this change ? It would help me a lot

Basically it's this, in PBGitSidebarView.xib, note the extra clearance that hopefully helps on older OSes:
PBGitSidebarView xib
Same in PBGitHistoryView.xib:
PBGitHistoryView xib
In RepositoryWindow.xib, as there's no "physical" status/footer bar, I've added a Horizontal Line just below the Split View:
RepositoryWindow xib

Sorry if the pull request didn't work, just tried to set everything up between work (web dev, apps are merely a hobby) and cooking dinner :(
This would be the commit
322e122

@insha
Copy link
Copy Markdown
Collaborator

insha commented Nov 15, 2022

@insha Do you understand what's going on in pull request ? There were no changes here at all.

security: SecKeychainItemImport: One or more parameters passed to a function were not valid.

image

@hannesa2 There isn't anything odd that sticks out in the pull request and looking at the screenshot, I double-checked the provisioning profile and the cert (in the Apple Developer portal) and both were valid.

The error looks like a command issue with the security import... in the workflow file... perhaps related to the macOS version that is used for this workflow.

@hannesa2
Copy link
Copy Markdown
Contributor

@insha Thanks a lot for having a look into it and double check.
After push branch from fork to upstream and retrigger it 5 times, suddenly it works with fork branch again. -no clue why-
Additionally I observed on an unknown reason the arm64 custom runner was removed. I added it again.

@hannesa2
Copy link
Copy Markdown
Contributor

I see no big diff on my macOS Ventura 13.0.1
master:
image
image

your PR
image
image

I'm fine with it 👍

@hannesa2 hannesa2 merged commit 84d7eea into gitx:master Nov 15, 2022
@elosha elosha deleted the guifixes branch November 15, 2022 09:57
@elosha
Copy link
Copy Markdown
Contributor Author

elosha commented Nov 15, 2022

@hannesa2 Works on High Sierra! Also there status bar separator looks good on Monterey.
highsierra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GUI glitches on High Sierra

3 participants