Consult the configuration whether to sign commits or not#327
Merged
tiennou merged 1 commit intogitx:masterfrom Aug 25, 2022
Merged
Consult the configuration whether to sign commits or not#327tiennou merged 1 commit intogitx:masterfrom
tiennou merged 1 commit intogitx:masterfrom
Conversation
This adds a config check for commit.gpgSign and changes the returned error to at least point the user at the underlying issue.
hannesa2
approved these changes
Aug 25, 2022
Contributor
Author
|
Thanks for the review @hannesa2 👍🚢 |
Contributor
|
Just for the records, when you assign a label, it will be in the changelog in a prominent position |
Contributor
Don't count on that too much. I'm only built the CI pipeline, made the arm64 build, keep the repository alive and prevent pull requests to keep open un-merged for years. This just frustrate developers and will prevent from new pull requests. I'm just a beginner developer in the macOS habitat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a config check for
commit.gpgSignand changes the returned error to at least point the user at the underlying issue.Slightly improves the situation over #326.