Correct artifact uploading of dmg and zip files#324
Merged
hannesa2 merged 1 commit intogitx:masterfrom Aug 9, 2022
Merged
Conversation
hannesa2
reviewed
Aug 9, 2022
| path: GitX-${{ matrix.abi }}.dmg | ||
| - name: Upload artifact | ||
| uses: actions/upload-artifact@v3 | ||
| if: ${{ success() }} |
Contributor
There was a problem hiding this comment.
Hmm, I'm not sure, if this if: ${{ success() }} is related to previous step, and not to the one more previous prepare step. Anyway, we can give it a try
Contributor
|
@jvanzyl How do you like it https://github.com/gitx/gitx/releases/tag/0.21 ? |
Contributor
Author
|
I will test the release artifacts now and report back. |
Contributor
Author
|
@hannesa2 I tried the ZIP distributions on an x86_64 and arm64 Mac and they work fine. I think they are good for releases now. |
Contributor
|
Thank you for testing. The pre- release was an accident |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.