GitX uses git commit-tree which appears to only do signing when -S is set.

Here's a small patch to add that, pending some configuration UI:

diff --git a/Classes/git/PBGitIndex.m b/Classes/git/PBGitIndex.m
index 77e65e6..fcf067d 100644
--- a/Classes/git/PBGitIndex.m
+++ b/Classes/git/PBGitIndex.m
@@ -273,6 +273,10 @@ - (void)commitWithMessage:(NSString *)commitMessage andVerify:(BOOL) doVerify
                [arguments addObject:@"-p"];
                [arguments addObject:parent];
        }
+       if (/* preference is set */ true) {
+               // commit-tree does not support the long --gpg-sign option for some reason
+               [arguments addObject:@"-S"];
+       }

        [self postCommitUpdate:@"Creating commit"];
        int ret = 1;

You'll also need to be using a graphical gpg-agent like MacGPG/GPGTools and add no-tty to ~/.gnupg/gpg.conf to tell gpg to not open /dev/tty (which doesn't exist in a GUI context). The latter could possibly be worked around by including a gpg wrapper script with GitX that adds --no-tty to its arguments, and pointing git -c gpg.program= at it.

How to enable GPG-signing of commits? #32

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions