Commit history - Git log (nodegit)#3579
Commit history - Git log (nodegit)#3579Publicker wants to merge 7 commits intogitthermal:feat/nodegit/git-logfrom
Conversation
* Change node_version to 10.16.0 * Define node & electron engines in package.json * FIX: Add comma after node version engine * Switch back to latest version of Node@10 * Split script command yarn and yarn build:window * Update "postinstall" script command to install electron app deps * Install electron app native deps * Merge yarn && yarn postinstall && yarn build:linux command * Test windows pipeline with npm * Upgrade nodegit & electron-builder package * Run pipeline in npm * Run audit fix * Run install && audit fix * install & audit fix & postinstall & build:window * Update build description * Move yarn to npm * Update echo command * Remove electron from engines
| logs.push(objectCommit); | ||
| }); | ||
| if (result !== 0) { | ||
| console.log("Error: " + result); |
There was a problem hiding this comment.
I don't know what to do if are any error. What is your suggestion?
)
There was a problem hiding this comment.
Well, we do need to build a separate notification section which includes to trigger notifications, alerts and more from anywhere.
But for now we can just log the error messages to console.
| import nodegit from "nodegit"; | ||
|
|
||
| const log = async path => { | ||
| const log = async (path, count = 50) => { |
There was a problem hiding this comment.
I put it 50 items by default. I think that is a good idea having the parameter just in case.
There was a problem hiding this comment.
Putting a hard-coded value 50 is not the best way to overcome this issue.
We need to think of better solution.
|
@Publicker Can you fix these conflicting files? |
| async gitLog() { | ||
| const logs = await gitLog(this.currentRepository.path); | ||
| this.$store.commit("history/updateLogs", { | ||
| logs: logs |
There was a problem hiding this comment.
Can you remove the part where you are storing the history inside Vuex Store.
Instead of storing commits in vuex store, we're storing them inside local data property.
|
@Publicker There are few comments which require your attention. |
Git log working with NodeGit!!!