test(label-list-item): Add missing tests for LabelListItem component#818
Merged
chinesedfan merged 1 commit intogitpoint:masterfrom Oct 4, 2018
Merged
Conversation
lex111
reviewed
Oct 2, 2018
| describe('<LabelListItem />', () => { | ||
| it('should render component with the correct label', () => { | ||
| const wrapper = shallow(<LabelListItem {...defaultProps} />); | ||
| expect(wrapper.find(LabelButton)).toHaveLength(1); |
Member
There was a problem hiding this comment.
@MarioArnt can you add a blank line before expect calls here and in other places?
Contributor
Author
There was a problem hiding this comment.
Done. Could be a good idea to use a linter for the unit tests code style.
37289ff to
7c38a51
Compare
lex111
approved these changes
Oct 3, 2018
chinesedfan
approved these changes
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for LabelListItem component