Add test for Migration Helper (#518)#814
Merged
lex111 merged 2 commits intogitpoint:masterfrom Oct 2, 2018
mbelsky:patch-1
Merged
Add test for Migration Helper (#518)#814lex111 merged 2 commits intogitpoint:masterfrom mbelsky:patch-1
lex111 merged 2 commits intogitpoint:masterfrom
mbelsky:patch-1
Conversation
lex111
requested changes
Oct 2, 2018
| @@ -0,0 +1,44 @@ | |||
| import {getRepoIdFromUrl, toOldIssueFormat, toOldUserFormat} from 'utils' | |||
Member
There was a problem hiding this comment.
Can you add spaces between curly braces?
import { getRepoIdFromUrl, toOldIssueFormat, toOldUserFormat } from 'utils'| state: 'StAte', | ||
| }; | ||
| const repoId = 'git-point'; | ||
|
|
Member
There was a problem hiding this comment.
Why is there a space? Let's add one a space between the variable declarations and the expect calls, and stick with it in all it blocks, what do you think?
const a = 'something';
const b = 'something else';
expect(...);
expect(...);
Contributor
Author
|
@lex111 Thanks for review, I've fixed that. |
lex111
approved these changes
Oct 2, 2018
Member
|
@mbelsky it's awesome, thanks! Happy Hacktoberfest! 🎃 |
Member
|
🎃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
There are a few tests for Migration Helper.