Skip to content

refactor(styled-components): migrate LoadingUserListItem#791

Merged
machour merged 1 commit intogitpoint:masterfrom
machour:refactor/sc/loading-user-list-item
Apr 30, 2018
Merged

refactor(styled-components): migrate LoadingUserListItem#791
machour merged 1 commit intogitpoint:masterfrom
machour:refactor/sc/loading-user-list-item

Conversation

@machour
Copy link
Copy Markdown
Member

@machour machour commented Apr 25, 2018

Question Response
Version? v1.4.1
Devices tested? iPhone 7
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #532

Screenshots

Before After
simulator screen shot - iphone 6 - 2018-04-25 at 17 22 58 simulator screen shot - iphone 6 - 2018-04-25 at 17 23 18

Description

Migrated LoadingUserListItem to SC

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 41.913% when pulling b134a18 on machour:refactor/sc/loading-user-list-item into 39d0de4 on gitpoint:master.

Copy link
Copy Markdown
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff my man 🎉

@machour machour merged commit 20a00af into gitpoint:master Apr 30, 2018
@machour machour deleted the refactor/sc/loading-user-list-item branch April 30, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants