Skip to content

chore(label): Migrate LabelButton#727

Merged
machour merged 2 commits intogitpoint:masterfrom
chinesedfan:pr_613
Feb 23, 2018
Merged

chore(label): Migrate LabelButton#727
machour merged 2 commits intogitpoint:masterfrom
chinesedfan:pr_613

Conversation

@chinesedfan
Copy link
Copy Markdown
Member

Question Response
Version? v1.4.1
Devices tested? iPhone 6 Simulator
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #532

Screenshots

Before After
6 pic 8 pic

Description

Migrate label-button.component.js to styled-components.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 45.144% when pulling d273fa3 on chinesedfan:pr_613 into d0fc33c on gitpoint:master.

@machour
Copy link
Copy Markdown
Member

machour commented Feb 23, 2018

Working fine on Android:

screen shot 2018-02-23 at 9 33 37 am

@machour machour merged commit 3b92054 into gitpoint:master Feb 23, 2018
@chinesedfan chinesedfan deleted the pr_613 branch July 12, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants