refactor: use styled-components in comment-list-item#723
Merged
machour merged 3 commits intogitpoint:masterfrom Feb 13, 2018
Merged
refactor: use styled-components in comment-list-item#723machour merged 3 commits intogitpoint:masterfrom
machour merged 3 commits intogitpoint:masterfrom
Conversation
machour
requested changes
Feb 12, 2018
Member
machour
left a comment
There was a problem hiding this comment.
Could you have a look at Travis?
| }, | ||
| }); | ||
| const Container = styled.View` | ||
| padding: 10px 10px 0 0; |
Member
There was a problem hiding this comment.
This seems to cause a Travis build failure, could you have a look?
Member
Author
There was a problem hiding this comment.
@machour It is due to my stylelint regular expression. Fixed now.
| `; | ||
|
|
||
| const ActionButtonIconContainer = styled.View` | ||
| padding: 5px 0 10px; |
machour
approved these changes
Feb 12, 2018
Member
machour
left a comment
There was a problem hiding this comment.
LGTM, tested on Android and iPhone simulators.
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Description
Based on #557. Thank @MrLoh all the same.