style: Update interface of badges in repository component#709
style: Update interface of badges in repository component#709machour merged 2 commits intogitpoint:masterfrom
Conversation
|
Hey, this is a fantastic way to start contributing, what a nice UI update 🎉 🎉 Left you some minor changes requests to stick to our coding habits. Could you also add yourself as a contributor using Thank you again for your PR! |
| marginLeft: 27, | ||
| marginRight: 27, | ||
| borderWidth: 0.5, | ||
| badge_view: { |
There was a problem hiding this comment.
badgeView would be me consistent with our code style
| }, | ||
| badge: { | ||
| color: colors.white, | ||
| fontWeight: 'bold', |
There was a problem hiding this comment.
Use ...fonts.fontPrimaryBold instead
|
This is so great @rkpasia 😍 . I knew those tags could use a little bit of love, but couldn't place my finger on what exactly it needed to look a little better. Aside from the tiny things @machour, this looks great. Also, please don't forget to add yourself as a contributor with |
|
@machour thanks for the feedback! 😄 In the last commit I've updated the code for consistency. @housseindjirdeh Thanks for the great words 😄I've added myself to the contributors list! Forgot about it ahah I'll reach out in gitter about the possibility to further get involved in the project 😄 |
Screenshots
Description
Hello! In this short commit I changed the styles associated with the badges in the repository component. I wasn't happy with the previous interface, so I tried to play with it and the results can be seen in the screenshots :)
I haven't created an issue or discussed with anyone else about this before doing it. So if it isn't accepted I understand, it just seemed a good way to start contributing to the project :)