Skip to content

refactor(sc): remove styledFonts in favor of fonts#693

Merged
housseindjirdeh merged 2 commits intogitpoint:masterfrom
machour:get-rid-of-styled-fonts
Jan 16, 2018
Merged

refactor(sc): remove styledFonts in favor of fonts#693
housseindjirdeh merged 2 commits intogitpoint:masterfrom
machour:get-rid-of-styled-fonts

Conversation

@machour
Copy link
Copy Markdown
Member

@machour machour commented Jan 14, 2018

Question Response
Version? v1.4.1
Devices tested? iPhone 7
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #688

Screenshots

Before After
simulator screen shot - iphone 6 - 2018-01-14 at 13 41 35 simulator screen shot - iphone 6 - 2018-01-14 at 13 22 20
simulator screen shot - iphone 6 - 2018-01-14 at 13 42 57 simulator screen shot - iphone 6 - 2018-01-14 at 13 23 46
simulator screen shot - iphone 6 - 2018-01-14 at 13 42 19 simulator screen shot - iphone 6 - 2018-01-14 at 13 24 09
simulator screen shot - iphone 6 - 2018-01-14 at 13 45 18 simulator screen shot - iphone 6 - 2018-01-14 at 13 46 46

Description

Got rid of styledFonts and used fonts in the same manner in all styled-components calls.
The syntax to use from now on would be the following:

const Foo = styled.Text`
  ${fonts.fontPrimarySemiBold};
  // ...

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 14, 2018

Coverage Status

Coverage decreased (-0.04%) to 43.274% when pulling 0b39cdb on machour:get-rid-of-styled-fonts into 608818e on gitpoint:master.

@machour machour mentioned this pull request Jan 15, 2018
Closed
housseindjirdeh
housseindjirdeh approved these changes Jan 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, thank you and thank you ❤️

@housseindjirdeh housseindjirdeh merged commit 7486649 into gitpoint:master Jan 16, 2018
@machour machour deleted the get-rid-of-styled-fonts branch January 16, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees

No one assigned

Labels

💅 styled-components ready for review refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@machour @coveralls @housseindjirdeh