refactor: migrate organization screen to styled-components#682
Merged
housseindjirdeh merged 2 commits intogitpoint:masterfrom Jan 3, 2018
ZahraTee:styled-components-organization-screen
Merged
refactor: migrate organization screen to styled-components#682housseindjirdeh merged 2 commits intogitpoint:masterfrom ZahraTee:styled-components-organization-screen
housseindjirdeh merged 2 commits intogitpoint:masterfrom
ZahraTee:styled-components-organization-screen
Conversation
Member
|
Since this is affecting the UI, could you provide us with two screenshots of the organization screen? |
machour
requested changes
Dec 28, 2017
| const styles = StyleSheet.create({ | ||
| listTitle: { | ||
| const DescriptionListItem = styled(ListItem).attrs({ | ||
| titleStyle: { |
Member
There was a problem hiding this comment.
I think this one can be removed (unused)
machour
approved these changes
Dec 28, 2017
Member
|
LGTM, thanks! |
andrewda
previously requested changes
Dec 28, 2017
Member
andrewda
left a comment
There was a problem hiding this comment.
Looks awesome thanks so much 🙏 Just one tiny change, then looks good to me
| ...fonts.fontPrimary, | ||
| }, | ||
| }); | ||
| })``; |
Member
There was a problem hiding this comment.
Can we remove this? Was probably just added by prettier for some reason, but I think you can safely get rid of it.
Member
There was a problem hiding this comment.
It's needed by styled components when using attrs()
Member
There was a problem hiding this comment.
Ahh alright, yes you're right.
andrewda
approved these changes
Dec 28, 2017
lex111
approved these changes
Dec 30, 2017
chinesedfan
approved these changes
Jan 2, 2018
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Part of #532.