refactor: repository-list-item to styled components#605
refactor: repository-list-item to styled components#605machour merged 3 commits intogitpoint:masterfrom
Conversation
|
Could you add before/after screenshots, as provided in the PR template? |
| fontFamily: styledFonts.fontPrimarySemiBold, | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
We should be able to get rid of this last one when #619 gets merged.
The <ListItem> can be then styled as follow:
const Repository = styled(ListItem).attrs({
titleStyle: {
color: colors.primaryDark,
fontFamily: styledFonts.fontPrimarySemiBold,
},
})``;the underlayColor prop can also be merged there as it's is a pure presentation prop
There was a problem hiding this comment.
#619 is merged, you should now be able to get rid of this last thingy 🎉
c2a8caf to
42091d2
Compare
Refactor RepositoryListItem using styled-components
|
I think everything is ready now 😃 |
|
Hi @apoeco and sorry for not getting back to you sooner 😞 Just had time to review this, and it's working flawlessly 🎉 I wanted to fix the conflicts for you, but it seems that I'm unable to do it because you didn't work on a branch of your fork, but rather on master directly. Could you take care of fixing them ? (You just need to retrieve the last We'll get this merged as soon as it's done, thank you again! |
machour
left a comment
There was a problem hiding this comment.
It would appear that my merge worked after a few hours. Weird.
Just noticed that you were using styledFonts that was removed not so long ago. Left you review comments with the exact changes to be made. Could you take care of this last thing please? 🙏
I'd happily merge this as is and do the changes for you if you're too busy, no worries!
| `; | ||
|
|
||
| const TitleText = ColoredText.extend` | ||
| font-family: ${styledFonts.fontPrimarySemiBold}; |
There was a problem hiding this comment.
Should be:
const TitleText = ColoredText.extend`
${fonts.fontPrimarySemiBold};
`;
| `; | ||
|
|
||
| const DescriptionText = ColoredText.extend` | ||
| font-family: ${styledFonts.fontPrimaryLight}; |
There was a problem hiding this comment.
Should be:
const DescriptionText = ColoredText.extend`
${fonts.fontPrimaryLight};
`;
| padding-left: 3; | ||
| padding-top: 2; | ||
| margin-right: 15; | ||
| font-family: ${styledFonts.fontPrimary}; |
| const Repository = styled(ListItem).attrs({ | ||
| titleStyle: { | ||
| color: colors.primaryDark, | ||
| fontFamily: styledFonts.fontPrimarySemiBold, |
There was a problem hiding this comment.
fontFamily: fonts.fontPrimarySemiBold.fontFamily,
|
|
||
| import { emojifyText, abbreviateNumber } from 'utils'; | ||
| import { colors, languageColors, fonts, normalize } from 'config'; | ||
| import { colors, languageColors, styledFonts, normalize } from 'config'; |
There was a problem hiding this comment.
use fonts instead of styledFonts
|
I’m on it! |
| padding-top: 2; | ||
| margin-right: 15; | ||
| font-family: ${styledFonts.fontPrimary}; | ||
| font-family: ${fonts.fontPrimary}; |
There was a problem hiding this comment.
Almost :D
Remove font-family: and we're good to go
|
Thank you!!! 🎉 🎉 🎉 🎉 🎉 |
Related #532
Screenshots