refactor: use styled-components in user-list-item#601
refactor: use styled-components in user-list-item#601chinesedfan merged 5 commits intogitpoint:masterfrom
Conversation
|
|
chinesedfan
left a comment
There was a problem hiding this comment.
@shmesa22 Nice job! Everything is fine expect the name of noBorderBottom.
| )} | ||
| underlayColor={colors.greyLight} | ||
| style={!noBorderBottom && styles.borderContainer} | ||
| noBorderBottom={!noBorderBottom} |
There was a problem hiding this comment.
hmm what do you mean by wired?
There was a problem hiding this comment.
@alejandronanez The prop name should be something like hasBorderBottom, because the value is !noBorderBottom.
| }, | ||
| }); | ||
| const ViewBorderContainer = styled.View` | ||
| border-bottom-color: ${props => props.hasBorderBottom && colors.greyLight}; |
There was a problem hiding this comment.
I think this will evaluate to a boolean and not work as expected .. shouldn't you be providing two different return values (just like the line below this one?)
There was a problem hiding this comment.
@shmesa22 Right. It will cause a invalid prop error.
I am eager to merge styled-components PRs and your PR is very very close to be merged. So forgive me to fix it in your branch directly. Normally I shouldn't do that.
| `; | ||
| const TouchableBorderContainer = ViewBorderContainer.withComponent( | ||
| TouchableHighlight | ||
| ); |
|
Ping here to @shmesa22 😄 |
Related #532