Merged
Conversation
andrewda
requested changes
Oct 28, 2017
TESTS.md
Outdated
| @@ -0,0 +1,84 @@ | |||
| # Guidelines about how to write your unit tests for Gitpoint | |||
Member
There was a problem hiding this comment.
Keep the title short. Maybe just Test Guidelines?
TESTS.md
Outdated
|
|
||
| it('should not render the Bar component when isOpen is falsy', () => { ... }); | ||
|
|
||
| it('should return 'the NAME' when foo received \'name\' as a param', () => { ... }); |
Member
There was a problem hiding this comment.
Either ... return \'the NAME\' ... or use double quotes and get rid of the backslashes for ... \'name\' ...
andrewda
requested changes
Oct 28, 2017
TESTS.md
Outdated
| @@ -0,0 +1,84 @@ | |||
| # Test guidlines | |||
Member
There was a problem hiding this comment.
Tiny typo: should be "Guidelines". Let's also use title case here (capital "G").
andrewda
approved these changes
Oct 28, 2017
Member
|
Oh man thank you @alejandronanez, this was really needed <3 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TEST guidelines. Let me know what do you think.
Closes #595