test: Add RepositoryProfile tests#531
Merged
alejandronanez merged 1 commit intomasterfrom Oct 21, 2017
Merged
Conversation
- Add tests for Repository Profile Component - Mock ‘react-native-safari-view’
alejandronanez
commented
Oct 20, 2017
| {repository.fork && ( | ||
| <Text style={[styles.subtitle, styles.subtitleFork]}> | ||
| <Text | ||
| nativeId="repository-fork-container" |
Member
Author
There was a problem hiding this comment.
I had to add this prop so it was possible to target this specific component in its test file.
nativeId is used for e2e tests Docs About nativeId
alejandronanez
commented
Oct 20, 2017
|
|
||
| jest.mock('react-native-code-push', () => ({})); | ||
|
|
||
| jest.mock('react-native-safari-view', () => ({})); |
Member
Author
There was a problem hiding this comment.
Mocking this so we don't get an error.
andrewda
reviewed
Oct 21, 2017
| const wrapper = shallow( | ||
| <RepositoryProfile {...defaultProps} loading={true} /> | ||
| ); | ||
| const theIcon = wrapper.find({ name: 'fiber-manual-record' }); |
Member
There was a problem hiding this comment.
It's a bit weird to use "the" in a variable name (unless you have a specific reason?) How about just const icon = wrapper.find({ name: 'fiber-manual-record' });
Member
Author
There was a problem hiding this comment.
Yeah that works too. Will update it on my next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #518