Skip to content

feat(translations): add Spanish translations#282

Merged
alejandronanez merged 4 commits intomasterfrom
spanish-translations__#233
Oct 7, 2017
Merged

feat(translations): add Spanish translations#282
alejandronanez merged 4 commits intomasterfrom
spanish-translations__#233

Conversation

@alejandronanez
Copy link
Copy Markdown
Member

@alejandronanez alejandronanez commented Sep 2, 2017

Hey, guys! This is the initial work for the Spanish translations, it's just a few lines but it's something.

Thanks!

Closes #233

@alejandronanez alejandronanez changed the title Spanish translations #233 feat(spanish translations) Sep 2, 2017
Copy link
Copy Markdown
Member

@andrewda andrewda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good! 👍

Copy link
Copy Markdown
Member

@SammyIsra SammyIsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far it looks good!

"Welcome! This is your news feed - it'll help you keep up with recent activity on repositories you watch and people you follow.",
commitCommentEvent: 'commented on commit',
createEvent: 'creado {{object}}',
deleteEvent: 'borrado {{object}}',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these two lines be {{object}} creado and {{object}} borrado?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense! IDK what I was thinking lol

@housseindjirdeh
Copy link
Copy Markdown
Member

Thanks for putting this PR up @alejandronanez. Even if it's a work in progress, I like having a discussion for it earlier rather than later :)

It really looks like it's coming together nicely 😍

@andrewda andrewda changed the title feat(spanish translations) feat(translations): add Spanish translations Sep 11, 2017
@machour machour mentioned this pull request Oct 3, 2017
@alejandronanez alejandronanez merged commit ee72c91 into master Oct 7, 2017
@alejandronanez alejandronanez deleted the spanish-translations__#233 branch October 7, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants