feat: add tests. coverage 100%

alejandronanez · alejandronanez · commit cf5e006b15a1 · 2017-10-28T11:34:21.000-05:00
diff --git a/.gitignore b/.gitignore
@@ -63,3 +63,5 @@ haste-map-react-native-packager*
 # editors
 .vscode
 .idea
+
+coverage
diff --git a/__tests__/tests/components/NotificationListItem.js b/__tests__/tests/components/NotificationListItem.js
@@ -4,6 +4,7 @@ import { NotificationListItem } from 'components';
 import { View, TouchableOpacity } from 'react-native';
 
 const defaultProps = {
+  id: 1,
   notification: {
     subject: {
       type: 'Commit',
@@ -57,5 +58,38 @@ describe('<NotificationListItem />', () => {
     expect(navigationActionMock).toHaveBeenCalledWith(notification);
   });
 
-  it.skip('should return the correct icon name');
+  it('should return the correct icon name', () => {
+    const wrapper = shallow(<NotificationListItem {...defaultProps} />);
+
+    expect(wrapper.instance().getIconName('commit')).toEqual('git-commit');
+    expect(wrapper.instance().getIconName('pullRequest')).toEqual(
+      'git-pull-request'
+    );
+    expect(wrapper.instance().getIconName('wrong data')).toEqual(
+      'issue-opened'
+    );
+  });
+
+  it('should call iconAction on press and notification is unread', () => {
+    const notification = {
+      id: 1,
+      subject: {
+        type: 'Commit',
+      },
+      unread: true,
+    };
+    const iconActionMock = jest.fn();
+    const wrapper = shallow(
+      <NotificationListItem
+        {...defaultProps}
+        notification={notification}
+        iconAction={iconActionMock}
+      />
+    );
+
+    wrapper.find({ nativeId: 'notification-unread' }).simulate('press');
+
+    expect(iconActionMock).toHaveBeenCalledWith(1);
+    expect(iconActionMock).toHaveBeenCalledTimes(1);
+  });
 });
diff --git a/src/components/notification-list-item.component.js b/src/components/notification-list-item.component.js
@@ -57,10 +57,8 @@ export class NotificationListItem extends Component {
     return notification.subject.type === 'Commit' ? View : TouchableOpacity;
   };
 
-  getIconName = () => {
-    const { notification } = this.props;
-
-    switch (notification.subject.type) {
+  getIconName = type => {
+    switch (type) {
       case 'commit':
         return 'git-commit';
       case 'pullRequest':
@@ -74,7 +72,7 @@ export class NotificationListItem extends Component {
     const { notification, iconAction, navigationAction } = this.props;
 
     const TitleComponent = this.getComponentType();
-    const iconName = this.getIconName();
+    const iconName = this.getIconName(notification.subject.type);
 
     return (
       <View style={styles.container}>
@@ -98,6 +96,7 @@ export class NotificationListItem extends Component {
 
           {notification.unread && (
             <TouchableOpacity
+              nativeId="notification-unread"
               style={styles.iconContainer}
               onPress={() => iconAction(notification.id)}
             >
