@jgallucci32 your PR is appreciated! Thanks a lot.

Please would you like to change the solution to not encode in the server component, so that decoding is no longer required in the proxy. 🙏

encodeURI is to be removed from https://github.com/gitpod-io/gitpod/blob/master/components/server/src/theia-plugin/theia-plugin-controller.ts#L57 instead of decoding in the proxy, simply because we don't need to do that in the server if it need to be reverted in the proxy anyways.

Thanks to @corneliusludmann! he just pointed out, that the explanation wasn't clear enough.

@AlexTugarev Yes I will do that, thank you for pointing out how it was encoded in the first place. After doing some reading I am in agreement. Apparently using encodingURI programmatically is discouraged and discussed in a few places as why it should be avoided.

Unfortunately, encodeURI has a critical flaw, which is that it escapes '%' characters, making it completely useless for URI cleaning (it will double-escape any URI that already had percent-escapes).

Reference: https://stackoverflow.com/questions/9245333/should-encodeuri-ever-be-used/9245778

/werft run

👍 started the job as gitpod-build-patch-2.0

https://werft.gitpod-dev.com/job/gitpod-build-patch-2.0 is green.
'just tested that upload works as expected.

@jgallucci32 thank you very much for you contribution 🎉