Enable commands on .gitignore #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2019 16:24
Allow gitless to track, untrack and resolve on files that start with .git EXCEPT for the very specific directory at the top level of the repo .git. For example, `gl track .gitignore` is fine, `gl track .git/HEAD` is not allowed. Another, `gl track .gitdir/some_file` is allowed, `gl track .git` will not be allowed.
spderosso
approved these changes
Oct 7, 2019
Member
|
Thanks for fixing this bug!
In some cases we use |
Member
|
hmm for some strange reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow gitless to track, untrack and resolve on files that start with
.git EXCEPT for the very specific directory at the top level of the repo
.git. For example,
gl track .gitignoreis fine,gl track .git/HEADis not allowed. Another,
gl track .gitdir/some_fileis allowed,gl track .gitwill not be allowed.Fixes #178 .
Made changes to the path processor and wrote unit tests against the path processor. Factored argparser out to a function so unit testing is easier.
The only issue(?) with this approach is that there is no error messaging. Gitless will ALWAYS silently drop the paths and do nothing. Git fatals and reports on the first path if all the paths are under .git/, otherwise it will silently drop the paths under .git/.
E.g.