Add project Template list #1127#1291
Merged
Merged
Conversation
10c8512 to
9d79920
Compare
Contributor
Author
jmini
reviewed
Oct 5, 2025
| * The token is revoked and a new one which will expire in one week is created to replace it. | ||
| * Only working with GitLab 16.0 and above. | ||
| * | ||
| *ProjectTemplate |
Collaborator
There was a problem hiding this comment.
This looks a wired addition to the javadoc
jmini
reviewed
Oct 5, 2025
| List<ProjectTemplate> projectTemplates = unmarshalResourceList(ProjectTemplate.class, "project-templates.json"); | ||
| assertTrue(compareJson(projectTemplates, "project-templates.json")); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Would it be possible to add a similar test for ProjectTemplateDetail.java
jmini
reviewed
Oct 5, 2025
| get(Response.Status.OK, queryParams, "projects", getProjectIdOrPath(projectIdOrPath), "iterations"); | ||
| return (response.readEntity(new GenericType<List<Iteration>>() {})); | ||
| } | ||
|
|
jmini
reviewed
Oct 5, 2025
| return (response.readEntity(new GenericType<List<ProjectTemplate>>() {})); | ||
| } | ||
|
|
||
| public ProjectTemplateDetail getProjectTemplate( |
9d79920 to
f78d450
Compare
Contributor
Author
|
Thanks @jmini, should be ok now :) |
jmini
approved these changes
Oct 26, 2025
jmini
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1127