Add work item support to WebHookManager#1215
Merged
Merged
Conversation
jmini
approved these changes
Dec 24, 2024
jmini
left a comment
Collaborator
There was a problem hiding this comment.
I am not really using the WebHookManager myself so I missed it when implementing the WorkItemEvent.
I think this addition makes sense, thank you for this pull-request.
Collaborator
|
🎉 merged! Maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the WorkItemEvent has been implemented but not added to the WebHookManager. With gitlab 17.7 new issues and epics use an object_kind of work_item when webhooks are sent.