Adds core infrastructure for Git commit signing by eamodio · Pull Request #4875 · gitkraken/vscode-gitlens

eamodio · 2026-01-13T04:46:23Z

Implements the implementation plan for Phase 1 of Git commit signing support, establishing the foundational architecture for cryptographic signing within the extension.

Core Infrastructure: Adds the ability to read and write signing configurations directly from Git global/local config, supporting GPG, SSH, and X.509 formats.
Signature Parsing: Updates the commits provider to lazily fetch and parse signatures from git logs, verifying status (good, bad, expired, etc.) and ownership.
Commit Creation: Enhances the patch provider to support signing when creating commits and unreachable commits, respecting the user's auto-sign configuration.
User Interface: Introduces a new status bar controller to display the current signing mode and a setup command to help users configure signing keys.
Integration: Hooks signing capabilities into the Composer feature, allowing generated commits to be signed.
Telemetry & Error Handling: Implements specific error handling for common signing issues (missing keys, passphrase failures) and adds telemetry events to track adoption and stability.

ianhattendorf · 2026-01-22T22:12:33Z

I've pushed up several commits. Still outstanding (highest priority at the top, roughly):

Signatures are being verified more often than they should be, leading to some delays in the UI
Need to display an icon on inline blame hovers
Test X.509 support
Should users be able to set up signing without an active repo? (Currently the config sub-provider requires a repoPath)

src/env/node/git/sub-providers/config.ts

src/webviews/apps/shared/components/commit/signature-badge.ts

src/commands/signing/setup.ts

package.json

ianhattendorf · 2026-01-24T00:29:38Z

Regarding the signature icon/tooltip for inline blame hovers: I don't believe it's possible to get a tooltip without making the icon a blue link. Not sure what we want to do here or if I'm missing something, I'll take another look next week.

augmentcode · 2026-01-26T19:03:53Z

🤖 Augment PR Summary

Summary: Adds foundational infrastructure for Git commit signing support (Phase 1) across GitLens, spanning config management, signature retrieval/parsing, UI indicators, and telemetry.

Changes:

Adds a new Setup Commit Signing... command with a quick-pick flow to enable signing and set a signing key globally.
Extends the Git config sub-provider to read/write signing-related keys (e.g., commit.gpgsign, gpg.format, signing programs, SSH allowed signers file).
Introduces per-commit signature retrieval via git log pretty-format fields and a new GitCommit.getSignature() cache.
Adds a signature parser for Git’s %G* format specifiers with unit tests covering multiple status/trust cases.
Updates hover commit formatting to support a ${signature} token and conditionally fetch signature info when enabled.
Enhances the Commit Details webview to fetch/serialize signature data and renders a new <gl-signature-badge> with tooltip details.
Updates patch/composer commit creation to optionally sign commits (commit-tree -S) and emits new signing telemetry events for success, setup, and failure reasons.
Adds new user settings under “Commit Signing” to toggle signature badges and future key generation support.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

src/env/node/git/sub-providers/patch.ts

src/git/parsers/signatureParser.ts

src/env/node/git/sub-providers/commits.ts

src/webviews/commitDetails/commitDetailsWebview.ts

ianhattendorf · 2026-01-26T19:41:28Z

augment review

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

src/commands/signing/setup.ts

src/env/node/git/sub-providers/config.ts

src/env/node/git/sub-providers/patch.ts

src/env/node/git/sub-providers/config.ts

src/git/gitProvider.ts

eamodio · 2026-01-27T18:19:44Z

Regarding the signature icon/tooltip for inline blame hovers: I don't believe it's possible to get a tooltip without making the icon a blue link. Not sure what we want to do here or if I'm missing something, I'll take another look next week.

Yeah, only links get tooltips I'm pretty sure

- Gates SSH and X509 signing options behind Git version requirements - Changes commit signing setup to configure globally - Adds commit signing VS Code fallback and boolean normalization - Replaces --show-signature with Git format specifiers - Uses SSH placeholder value if nothing entered by user

- Adds the `${signature}` token into default commit and status tooltip formats

- Adds support for inferring GPG, SSH, and X.509 signature formats - Enhances signature tooltips with clearer verification status and key details - Integrates signature badges directly into the commit author component for better visibility Improves accessibility by updating custom chips to use native buttons and better focus management

- Adds a lightweight method to check for commit signatures - Adds short ttl caching to signature check results - Adopts the lightweight check in hovers and views

eamodio · 2026-01-30T05:19:04Z

This is ready IMO, though I've disabled the setup wizard for now.

eamodio assigned ianhattendorf Jan 13, 2026

eamodio added this to the 17.10 milestone Jan 13, 2026

ianhattendorf force-pushed the feature/commit-signing branch from e9ee95f to 1beb5c2 Compare January 22, 2026 22:12

ianhattendorf reviewed Jan 22, 2026

View reviewed changes

ianhattendorf force-pushed the feature/commit-signing branch 3 times, most recently from 7df0d2c to e712240 Compare January 26, 2026 18:38

ianhattendorf marked this pull request as ready for review January 26, 2026 18:50

ianhattendorf force-pushed the feature/commit-signing branch from e712240 to c275544 Compare January 26, 2026 18:59

augmentcode bot reviewed Jan 26, 2026

View reviewed changes

src/env/node/git/sub-providers/patch.ts Show resolved Hide resolved

src/git/parsers/signatureParser.ts Show resolved Hide resolved

src/env/node/git/sub-providers/commits.ts Outdated Show resolved Hide resolved

src/webviews/commitDetails/commitDetailsWebview.ts Outdated Show resolved Hide resolved

augmentcode bot reviewed Jan 26, 2026

View reviewed changes

src/commands/signing/setup.ts Show resolved Hide resolved

src/env/node/git/sub-providers/config.ts Outdated Show resolved Hide resolved

eamodio commented Jan 26, 2026

View reviewed changes

src/env/node/git/sub-providers/config.ts Outdated Show resolved Hide resolved

eamodio commented Jan 26, 2026

View reviewed changes

src/env/node/git/sub-providers/patch.ts Outdated Show resolved Hide resolved

eamodio commented Jan 26, 2026

View reviewed changes

src/env/node/git/sub-providers/config.ts Show resolved Hide resolved

eamodio commented Jan 26, 2026

View reviewed changes

src/git/gitProvider.ts Outdated Show resolved Hide resolved

ianhattendorf force-pushed the feature/commit-signing branch from d52d042 to 9ffe55e Compare January 27, 2026 18:46

eamodio force-pushed the feature/commit-signing branch from 9ffe55e to c2aa595 Compare January 29, 2026 17:01

eamodio and others added 7 commits January 29, 2026 10:53

Adds commit verification badge + tooltip to commit details

60eeb9a

Add inline blame hover signature icon

18d225b

Adds tests for signature badge verification

22ff906

Repository resolution + config optimization

31d3bb8

Respect signing.showSignatureBadges, optimizations

b3acc26

Use standard type import syntax

e6e781c

ianhattendorf force-pushed the feature/commit-signing branch from c2aa595 to e6e781c Compare January 29, 2026 17:53

eamodio added 4 commits January 29, 2026 21:23

Disables commit signing setup command for now

f86de76

Adds commit signature to view/graph hovers

6873afa

- Adds the `${signature}` token into default commit and status tooltip formats

Optimizes commit signature detection

610defe

- Adds a lightweight method to check for commit signatures - Adds short ttl caching to signature check results - Adopts the lightweight check in hovers and views

eamodio requested a review from ianhattendorf January 30, 2026 05:18

ianhattendorf approved these changes Jan 30, 2026

View reviewed changes

ianhattendorf merged commit 84ba8fb into main Jan 30, 2026
6 checks passed

ianhattendorf linked an issue Jan 30, 2026 that may be closed by this pull request

Signing commits with GitLens "Compose Commits" feature #4552

Closed

eamodio deleted the feature/commit-signing branch January 31, 2026 22:50

Conversation

eamodio commented Jan 13, 2026

Uh oh!

ianhattendorf commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ianhattendorf commented Jan 24, 2026

Uh oh!

augmentcode bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ianhattendorf commented Jan 26, 2026

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eamodio commented Jan 27, 2026

Uh oh!

eamodio commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ianhattendorf commented Jan 22, 2026 •

edited

Loading

augmentcode bot commented Jan 26, 2026 •

edited

Loading