Uses PAT on shared provider library requests from Azure#4272
Merged
Conversation
Contributor
Author
|
@sergeibbb Since your integration currently works without these changes, please verify that they do not break any of the existing Azure DevOps functionality. You will probably need to clear your stored Azure account, organizations, projects, etc. to test it properly. |
eamodio
approved these changes
Apr 30, 2025
Member
eamodio
left a comment
There was a problem hiding this comment.
I pushed a commit to avoid btoa and uses our base64 function
Member
|
@axosoft-ramint ok. I'll test it tomorrow |
Contributor
Author
|
Going to merge this and test in pre-release. |
Member
|
@axosoft-ramint I confirm that on my old Azure integration it keeps receiving my organizations with the new code. I've tested retrieving data for Launchpad, get-pr-for-commit, get-account-for-commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4271
Forces the use of a PAT (and converts the token to PAT) on almost all shared library calls from Azure, except for
getCurrentUserwhich does not support it.Note that we may need to update local queries as well using the same logic.