Updates Launchpad search UX to avoid always searching with the API#3856
Merged
Updates Launchpad search UX to avoid always searching with the API#3856
Conversation
c0b32cc to
1051707
Compare
Separates search in 3 modes: filtering, url search, & search mode - Introduces dedicated search mode UI with clearer user feedback - Consolidates GitHub/GitLab PR URL parsing into a single utility - Reduces UI flicker during searches with optimistic updates
1051707 to
a410551
Compare
eamodio
approved these changes
Dec 16, 2024
Member
eamodio
left a comment
There was a problem hiding this comment.
Pushed more experience changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3855
Current approach has some hacky workarounds to accommodate:
Suggestions welcome