Skip to content

Change branch create and branch rename into normal commands#3596

Merged
eamodio merged 2 commits intomainfrom
feature/#3528-part1_make_branch_create_and_rename_normal_cmds
Sep 27, 2024
Merged

Change branch create and branch rename into normal commands#3596
eamodio merged 2 commits intomainfrom
feature/#3528-part1_make_branch_create_and_rename_normal_cmds

Conversation

@sergiolms
Copy link
Contributor

@sergiolms sergiolms commented Sep 20, 2024

Description

This is the first part of #3528 that changes branch create and branch rename into normal commands.
Since GitLens performs most of the validation for branch names, there wasn't really much to error check here.

Preparing next PR with branch delete which will probably contain more validations.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergiolms sergiolms self-assigned this Sep 20, 2024
@sergiolms sergiolms mentioned this pull request Sep 20, 2024
Closed
@sergiolms sergiolms linked an issue Sep 20, 2024 that may be closed by this pull request
Change branch terminal-run commands into normal commands w/ proper error handling #3528
Closed
@sergiolms sergiolms force-pushed the feature/#3528-part1_make_branch_create_and_rename_normal_cmds branch 4 times, most recently from 3c7adf3 to 8b2779d Compare September 25, 2024 15:08
@eamodio eamodio force-pushed the feature/#3528-part1_make_branch_create_and_rename_normal_cmds branch from 8b2779d to 09b08cb Compare September 26, 2024 21:27
eamodio
eamodio approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiolms I pushed a bunch of changes to this. Please look through them and if you have any questions, let me know.

@eamodio eamodio mentioned this pull request Sep 26, 2024
Closed
7 tasks
sergiolms and others added 2 commits September 27, 2024 15:54
@sergiolms
Adds branchCreate and branchRename methods
d2c6ebd
@eamodio @sergiolms
Refactors branch creation and renaming
aae8254 
 - Moves error handling outside of GitProviderService (to allow callers control over handling)
- Splits unified branch command into specific calls and makes them optional

Refs #3528
@sergiolms sergiolms force-pushed the feature/#3528-part1_make_branch_create_and_rename_normal_cmds branch from 09b08cb to aae8254 Compare September 27, 2024 13:54
@eamodio eamodio merged commit 28e7774 into main Sep 27, 2024
@sergiolms sergiolms deleted the feature/#3528-part1_make_branch_create_and_rename_normal_cmds branch September 30, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamodio eamodio eamodio approved these changes

@ramin-t ramin-t Awaiting requested review from ramin-t

@sergeibbb sergeibbb Awaiting requested review from sergeibbb

Assignees

@sergiolms sergiolms

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change branch terminal-run commands into normal commands w/ proper error handling

2 participants

@sergiolms @eamodio