Conversation
478ba78 to
6f41d91
Compare
a842537 to
a291f0b
Compare
eamodio
approved these changes
Oct 2, 2024
but note the testing comment
Comment on lines
+158
to
+161
| if (args.state.flags != null) { | ||
| counter++; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I'm a little concerned about this -- since it could impact a bunch of flows, so will need to be tested.
Comment on lines
+307
to
+320
| .codicon-custom-git-branch-create { | ||
| &:before { | ||
| content: '\ea68'; | ||
| } | ||
| &:after { | ||
| content: '\ea60'; | ||
| position: absolute; | ||
| right: 0; | ||
| bottom: 0; | ||
| font-size: 0.6em; | ||
| line-height: normal; | ||
| transform: translate(-50%, 0%); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This is fine for here, but a new GlIcon that we can use in other places would be nice.
b47e03a to
1091131
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2024-08-29.at.16.09.54.mov
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses