Skip to content

Fixes multiple patch creation#3415

Merged
nzaytsev merged 2 commits intomainfrom
bugs/3414-patch-creation-may-be-done-multiple-times
Jul 29, 2024
Merged

Fixes multiple patch creation#3415
nzaytsev merged 2 commits intomainfrom
bugs/3414-patch-creation-may-be-done-multiple-times

Conversation

@nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Jul 23, 2024 •
edited
Loading

Description

Disables create {draftName} button after first click

Then, enable if creation has been failed

Screen.Recording.2024-07-23.at.13.52.41.mov

No need to reactivate the button if the creation is success

Screen.Recording.2024-07-23.at.13.53.03.mov

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Jul 23, 2024 that may be closed by this pull request
Patch creation may be done multiple times #3414
Closed
@nzaytsev nzaytsev requested review from d13 and eamodio July 23, 2024 07:00
@nzaytsev
Fixes multiple patch creation
6a06abe 
- disable create button after first click
- enable create button after creation error (on state change)
@nzaytsev nzaytsev force-pushed the bugs/3414-patch-creation-may-be-done-multiple-times branch from 397d947 to 6a06abe Compare July 25, 2024 03:21
eamodio
eamodio reviewed Jul 26, 2024
View reviewed changes
CHANGELOG.md Outdated
### Fixed

- Fixes cloud patch creation error on azure repos
- Fixes multiple patch creation
Copy link
Member

@eamodio eamodio Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference the GH issue

Copy link
Contributor Author

@nzaytsev nzaytsev Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

eamodio
eamodio approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll let @d13 have the final call.

@eamodio eamodio added this to the 15.3 milestone Jul 26, 2024
d13
d13 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@nzaytsev nzaytsev merged commit 7a93258 into main Jul 29, 2024
@nzaytsev nzaytsev deleted the bugs/3414-patch-creation-may-be-done-multiple-times branch September 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

@eamodio eamodio eamodio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15.3

Development

Successfully merging this pull request may close these issues.

Patch creation may be done multiple times

3 participants

@nzaytsev @d13 @eamodio