Fixes #3197 - Only emojify standalone emojis#3208
Merged
eamodio merged 1 commit intogitkraken:mainfrom Apr 8, 2024
m4rch3n1ng:emoji-regex
Merged
Fixes #3197 - Only emojify standalone emojis#3208eamodio merged 1 commit intogitkraken:mainfrom m4rch3n1ng:emoji-regex
eamodio merged 1 commit intogitkraken:mainfrom
m4rch3n1ng:emoji-regex
Conversation
eamodio
reviewed
Mar 30, 2024
Member
|
Thank you for your contribution! |
|
This breaks just about every commit message I've written on another account. |
Contributor
Author
|
@KrombopulosMichael then open a new issue, where you detail your problem and then people may be able to fix that. vaguely complaining here likely won't help you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3197
Extend the
emojiRegexto onlyemojifyemojis that are delimited by a space (as in"text :emoji: text"), or with a line start / line end (as in":emoji: text"or"text :emoji:")(as a side note: i wanted to write a few tests to ensure this works, but i couldn't figure out where to place them so i just left it)
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses