Skip to content

Fixes #1718 adds open current branch on remote#1950

Merged
eamodio merged 1 commit intogitkraken:mainfrom
d13:feature/open-current-branch-on-remote
Jun 13, 2022
Merged

Fixes #1718 adds open current branch on remote#1950
eamodio merged 1 commit intogitkraken:mainfrom
d13:feature/open-current-branch-on-remote

Conversation

@d13
Copy link
Member

@d13 d13 commented Apr 6, 2022

Description

Adds a command palette action to "Open Current Branch on Remote".

Fixes #1718

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@d13 d13 marked this pull request as ready for review April 14, 2022 00:35
@eamodio eamodio self-requested a review June 13, 2022 07:58
package.json Outdated
Comment on lines +8760 to +8764
{
"command": "gitlens.openCurrentBranchOnRemote",
"when": "viewItem =~ /gitlens:branch\\b(?=.*?\\b\\+(tracking|remote)\\b)/",
"group": "inline@100"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that this is a duplication issue, as it doesn't really make sense. Since if we are opening the context menu for a branch, I don't think we want an option to open the current branch.

package.json Outdated
Comment on lines +8826 to +8830
{
"command": "gitlens.openCurrentBranchOnRemote",
"when": "viewItem =~ /gitlens:branch\\b(?=.*?\\b\\+(tracking|remote)\\b)/",
"group": "2_gitlens_quickopen@2"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

package.json Outdated
Comment on lines +9519 to +9523
{
"command": "gitlens.openCurrentBranchOnRemote",
"when": "gitlens:hasRemotes && !gitlens:readonly && !gitlens:untrusted && !gitlens:hasVirtualFolders && viewItem =~ /gitlens:status:upstream:(?!none)/",
"group": "inline@100"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While slightly different than above, it also doesn't make sense.

package.json Outdated
Comment on lines +9565 to +9569
{
"command": "gitlens.openCurrentBranchOnRemote",
"when": "gitlens:hasRemotes && !gitlens:readonly && !gitlens:untrusted && !gitlens:hasVirtualFolders && viewItem =~ /gitlens:status:upstream:(?!none)/",
"group": "2_gitlens_quickopen@2"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@d13 d13 force-pushed the feature/open-current-branch-on-remote branch from 72bc4e9 to ab87069 Compare June 13, 2022 14:42
- adds command palette action
@d13 d13 force-pushed the feature/open-current-branch-on-remote branch from ab87069 to 404c88e Compare June 13, 2022 15:01
@eamodio eamodio merged commit 225fa39 into gitkraken:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[command] Open current branch on remote

2 participants