Skip to content

Adds filter button to graph search box#3686

Merged
ramin-t merged 2 commits intomainfrom
feature/graph-filter-search
Oct 21, 2024
Merged

Adds filter button to graph search box#3686
ramin-t merged 2 commits intomainfrom
feature/graph-filter-search

Conversation

@ramin-t
Copy link
Contributor

@ramin-t ramin-t commented Oct 18, 2024

Having the button enabled allows you to filter when searching the graph.

Requires this PR merged as a pre-requisite, and dependency updated, before it can leave draft: https://github.com/gitkraken/GitKrakenComponents/pull/359

@ramin-t ramin-t requested review from d13 and eamodio October 18, 2024 22:52
@ramin-t ramin-t added area-graph Issues or features related to the Commit Graph feature labels Oct 18, 2024
@ramin-t ramin-t force-pushed the feature/graph-filter-search branch from 7e54234 to 13df9d7 Compare October 21, 2024 16:56
@ramin-t ramin-t marked this pull request as ready for review October 21, 2024 16:58
@ramin-t
Copy link
Contributor Author

ramin-t commented Oct 21, 2024

@eamodio @d13 The dependency is now merged and this is ready to review/merge.

Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though we might want to remember the toggle state.

@ramin-t ramin-t merged commit f43688f into main Oct 21, 2024
@ramin-t ramin-t deleted the feature/graph-filter-search branch October 21, 2024 22:56
@d13 d13 linked an issue Nov 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-graph Issues or features related to the Commit Graph

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the filtered out commits in commits graph

3 participants