Skip to content

Replace all slashes in ref for git provider URI#3060

Merged
d13 merged 1 commit intogitkraken:mainfrom
ian-h-chamberlain:fix/replace-all-slashes
Dec 15, 2023
Merged

Replace all slashes in ref for git provider URI#3060
d13 merged 1 commit intogitkraken:mainfrom
ian-h-chamberlain:fix/replace-all-slashes

Conversation

@ian-h-chamberlain
Copy link
Contributor

@ian-h-chamberlain ian-h-chamberlain commented Dec 15, 2023

Description

Simple follow-up fix to 095b469 for #2926

Since remote refs can have a slash, this fixes cases where the selection revision came from a remote, e.g. origin/release/5.0.

Before:

Screenshot 2023-12-15 at 09 24 05

After:

Screenshot 2023-12-15 at 09 23 34

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@ian-h-chamberlain ian-h-chamberlain marked this pull request as ready for review December 15, 2023 14:42
@d13 d13 self-assigned this Dec 15, 2023
@d13 d13 added this to the 14.7 milestone Dec 15, 2023
@d13 d13 added the bug label Dec 15, 2023
@d13 d13 merged commit edef2ce into gitkraken:main Dec 15, 2023
@d13
Copy link
Member

d13 commented Dec 15, 2023

Thanks @ian-h-chamberlain!

@d13 d13 added the pending-release Resolved but not yet released to the stable edition label Dec 15, 2023
@ian-h-chamberlain ian-h-chamberlain deleted the fix/replace-all-slashes branch December 15, 2023 17:34
@ramin-t ramin-t removed the pending-release Resolved but not yet released to the stable edition label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants