-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Description
Sometimes when I open a commit in the Commit Details view, it appears for about a second and then disappears, replaced by the empty boilerplate. This is kind of an intermittent issue but it seems like it consistently happens the first time I open a commit in that view while the view is initially closed and empty (regardless of what entrypoint I take to get there), and only intermittently for subsequent attempts. I generally have to activate the commit details entrypoint twice on that first attempt. I have the Commit Details view moved to the secondary sidebar, as GitLens recommends.
I'm guessing this is a result of the "Show Commit Details" command interfering with the Commit Details view's automatic line blame-esque behavior, where it shows me the details of the commit blamed for whatever line my cursor is currently on. If the view is not already open then I guess it's effectively empty. And using "Show Commit Details" (which I have configured to open in this view) or clicking a commit hash in a hover causes the view to be opened and immediately show the commit that I clicked on. But then it updates according to some other logic.
It seems like if I just open the secondary sidebar on its own by clicking its button, the view always starts blank (unless I previously pinned a commit to it). And then if I start clicking around a file while it's open, it'll show me commit details for the line blame. And then while a commit is open in the view, if I close the view (using the secondary sidebar UI button) and re-open it, the commit I previously had open appears for a moment before disappearing.
I suspect this is the same issue I mentioned above, it's just less pathological because the action I took was not expressly trying to open a specific commit. I think it should probably still keep the previous commit if what it's going to update to is nothing at all. But the more serious issue is the first one I mentioned — when the Commit Details view is opened by a user action that intentionally opened a specific commit in the view, that commit appears momentarily before disappearing. I think the view should not try to update automatically when opened if it was opened by an action that specified a particular commit. Hope that makes sense and sorry if it sounds obtuse, I guess this issue just happens to involve a lot of jargon 😬
GitLens Version
v2022.12.304
VS Code Version
Version: 1.73.1 (user setup)
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-09T04:27:29.066Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: No
Git Version
git version 2.38.1.windows.1