Merged
Conversation
This is needed because Licensed is locked to these versions as it uses specific bundler internals.
pchaigno
approved these changes
Jan 16, 2019
Member
Author
Not sure when, but my colleague has it on his list of things to test and see if anything breaks. Once it updates to 2.x, we can revert this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in #4340, tests are starting to fail because Travis has decided to switch to Bundler 2.x by default as of 3 Jan 2019 - https://docs.travis-ci.com/user/languages/ruby/#bundler-20 - and this is clashing with Licensed which expressly requires
~>1.10due to it using some internal bundler functionality.This PR locks us to bundler
~>1.10too.It took a few attempts for me to get Travis to actually do what I want it to do as the documented method wasn't working 😞 but I got there in the end.
Template removed as it's not relevant