Don't treat go.mod as a "generated" file#4357
Closed
borgstrom wants to merge 1 commit intogithub-linguist:masterfrom
Closed
Don't treat go.mod as a "generated" file#4357borgstrom wants to merge 1 commit intogithub-linguist:masterfrom
borgstrom wants to merge 1 commit intogithub-linguist:masterfrom
Conversation
1d09157 to
28d908f
Compare
Author
|
I totally missed #4340... Closing in favor of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's true that the
gotool does modifygo.modI would like to propose thatgo.modbe excluded from being treated as a "generated" file since understanding changes to it are a crucial part of the review process.For example, here's the default files view from a recent PR to a project that groomed some dependencies:
A reviewer must "load diff" on
go.mod. And for PRs that have lots of changes across many files it is easy to gloss over the two collapsed files without actually expanding the contents ofgo.mod.From a precedence standpoint
dep(Gopkg.toml&Gopkg.lock) has similar properties in thatdepmodifiesGopkg.toml, but onlyGopkg.lockis considered "generated".Thanks!