Skip to content

go: do not treat go.{mod,sum} modules files as generated#4333

Closed
myitcv wants to merge 1 commit intogithub-linguist:masterfrom
myitcvforks:fix_go_mod_sum
Closed

go: do not treat go.{mod,sum} modules files as generated#4333
myitcv wants to merge 1 commit intogithub-linguist:masterfrom
myitcvforks:fix_go_mod_sum

Conversation

@myitcv
Copy link
Copy Markdown

@myitcv myitcv commented Nov 19, 2018

As a follow up to #4306 (comment), go.{mod,sum} modules files should not be treated as generated.

Description

Per above.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.

Copy link
Copy Markdown
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do a git revert instead and mention the reverted commit in your commit message?

@myitcv
Copy link
Copy Markdown
Author

myitcv commented Nov 19, 2018

@pchaigno I'll leave it to to you/one of the repo owners to do the revert. I only pushed up this PR in case you want to make a minimal change instead of reverting.

@pchaigno
Copy link
Copy Markdown
Contributor

I'm not sure I see how this is semantically different from a git revert commit...?

@myitcv
Copy link
Copy Markdown
Author

myitcv commented Nov 19, 2018

The revert PR with links etc can be automatically generated from the old PR by someone with the right access. I don't have that option

@pchaigno
Copy link
Copy Markdown
Contributor

I meant the git revert command, after which you can push to a pull request.

@myitcv
Copy link
Copy Markdown
Author

myitcv commented Nov 19, 2018

Yes that's an option, but by far the easiest option is to auto-generate the revert PR from GitHub. On the assumption that's what's going to be most likely chosen here I'll close this PR

@myitcv myitcv closed this Nov 19, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants