go: do not treat go.{mod,sum} modules files as generated#4333
go: do not treat go.{mod,sum} modules files as generated#4333myitcv wants to merge 1 commit intogithub-linguist:masterfrom
Conversation
pchaigno
left a comment
There was a problem hiding this comment.
Could you do a git revert instead and mention the reverted commit in your commit message?
|
@pchaigno I'll leave it to to you/one of the repo owners to do the revert. I only pushed up this PR in case you want to make a minimal change instead of reverting. |
|
I'm not sure I see how this is semantically different from a git revert commit...? |
|
The revert PR with links etc can be automatically generated from the old PR by someone with the right access. I don't have that option |
|
I meant the git revert command, after which you can push to a pull request. |
|
Yes that's an option, but by far the easiest option is to auto-generate the revert PR from GitHub. On the assumption that's what's going to be most likely chosen here I'll close this PR |
As a follow up to #4306 (comment),
go.{mod,sum}modules files should not be treated as generated.Description
Per above.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality