fix: add --project flag to uv entrypoint for GitHub Actions compatibility#700
Merged
fix: add --project flag to uv entrypoint for GitHub Actions compatibility#700
Conversation
…lity Signed-off-by: Jason Meridth <jmeridth@gmail.com> Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime regression in the Docker-based GitHub Action caused by GitHub Actions overriding the container working directory, which prevented uv run from discovering the project and its virtual environment.
Changes:
- Update the Docker
ENTRYPOINTto include--project /action/workspacesouvconsistently resolvespyproject.tomland the.venvregardless of runtime--workdir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The uv migration introduced a runtime regression in the Docker image. GitHub Actions' Docker container runner overrides the working directory to
/github/workspacevia--workdir, which causesuv runto not find thepyproject.tomlat/action/workspace. It falls back to system Python (which has no packages installed), resulting in:Fix
Add
--project /action/workspaceto theENTRYPOINTsouvalways discovers the project and its.venvregardless of the runtime working directory.Testing
Verified locally with Docker:
--workdir /github/workspace)ModuleNotFoundError: No module named 'github3'❌--project /action/workspace)