Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github-community-projects/issue-metrics
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.2.0
Choose a base ref
...
head repository: github-community-projects/issue-metrics
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.2.1
Choose a head ref
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on Mar 28, 2026

  1. fix: correct TypeError test to actually exercise exception handler

    The test_measure_time_to_first_review_type_error_path test was passing
    but not actually reaching the except TypeError block. The MagicMock
    review's submitted_at (a MagicMock, not a datetime) caused
    ignore_comment to skip the review as 'pending', so first_review_time
    stayed None and the function returned before the TypeError could occur.
    
    Use side_effect to raise TypeError directly from the reviews() call,
    which properly exercises the exception handling path.
    
    Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    zkoppert and Copilot committed Mar 28, 2026
    Configuration menu
    Copy the full SHA
    7a3a883 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #715 from github-community-projects/fix/test-time-…

    …to-first-review-type-error
    
    fix: correct TypeError test to exercise exception handler
    zkoppert authored Mar 28, 2026
    Configuration menu
    Copy the full SHA
    ff28a0c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2026

  1. Configuration menu
    Copy the full SHA
    7bee6e6 View commit details
    Browse the repository at this point in the history
Loading