Skip to content

feat: Add missing executables and generated#2896

Merged
shiftkey merged 1 commit intogithub:masterfrom
erdaltsksn:master
Dec 18, 2018
Merged

feat: Add missing executables and generated#2896
shiftkey merged 1 commit intogithub:masterfrom
erdaltsksn:master

Conversation

@erdaltsksn
Copy link
Contributor

Reasons for making this change:

There are missing sections that should be added to .gitignore

Links to documentation supporting these rule changes:

https://gohugo.io/hugo-pipes/introduction/

@shiftkey
Copy link
Member

@erdtsksn any links to StackOverflow discussions or other documentation about this change?

@erdaltsksn
Copy link
Contributor Author

@erdtsksn any links to StackOverflow discussions or other documentation about this change?

https://discourse.gohugo.io/t/why-does-hugo-create-the-resources-directory/13021/4

https://discourse.gohugo.io/t/why-does-hugo-create-the-resources-directory/13021/3
bep who is one of the core contributor said you may add it to git if you like. But also he stated it is a resource cache. In my opinion it should be in gitignore if it is cache.

https://github.com/netlify-templates/one-click-hugo-cms/tree/master/bin
Netlify have a one-click template to create hugo websites. As you may see in the link above. They include hugo binaries inside bin folder.

@shiftkey
Copy link
Member

@erdtsksn great, thanks for the extra context!

@shiftkey shiftkey merged commit a53b4a3 into github:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants