Merged
Conversation
Contributor
Author
|
TODO: on leaving hibernation, This is somewhat complicated to achieve and supervise, since most of these processes are independent. |
added 2 commits
May 24, 2017 10:42
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418
This PR introduces
--critical-load-hibernate-seconds. This flag defaults0(in which case the new feature introduced in this PR is disabled)when
critical-load-hibernate-seconds > 0, then the behavior ofcritical-loadchanges. Instead of panicking and bailing out with error,gh-ostenters hibernation.As opposed to throttling, hibernation implies absolutely no queries on neither master not migrated server. No heartbeats; no throttle checks; no replication lag checks; nothing.
When
gh-ostawakes from hibernation, it's all back to normal, and throttling checks take place as usual, and of course it may potentially re-enter hibernation ifcritical-loadis still met.cc @ggunson @github/database-infrastructure